Fix non-corruption in testCurrentHeaderVersion #50883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we make multiple attempts to corrupt the translog header in
`TranslogHeaderTests#testCurrentHeaderVersion`, but if we are extraordinarily
unlucky then this sequence of corruptions may restore the file to its original
state. An example of such an extraordinarily unlucky run is as follows.
./gradlew ':server:test' --tests "org.elasticsearch.index.translog.TranslogHeaderTests.testCurrentHeaderVersion"
-Dtests.seed=FA72F7F56C4B3643 -Dtests.security.manager=true -Dtests.jvms=4
-Dtests.locale=es-GT -Dtests.timezone=Europe/Budapest -Dcompiler.java=13
Log output:
1> [2020-01-11T00:58:32,320][INFO ][o.e.i.t.TranslogHeaderTests] [testCurrentHeaderVersion] before test
1> [2020-01-11T00:58:32,322][INFO ][o.e.i.t.TranslogHeaderTests] [testCurrentHeaderVersion] corruptFile: corrupting file /home/davidturner/elasticsearch/server/build/testrun/test/temp/org.elasticsearch.index.translog.TranslogHeaderTests_FA72F7F56C4B3643-001/tempDir-002/translog-6712189936700025777.tlog at position 6 turning 0x72 into 0x63
1> [2020-01-11T00:58:32,323][INFO ][o.e.i.t.TranslogHeaderTests] [testCurrentHeaderVersion] corruptFile: corrupting file /home/davidturner/elasticsearch/server/build/testrun/test/temp/org.elasticsearch.index.translog.TranslogHeaderTests_FA72F7F56C4B3643-001/tempDir-002/translog-6712189936700025777.tlog at position 6 turning 0x63 into 0x72
1> [2020-01-11T00:58:32,324][INFO ][o.e.i.t.TranslogHeaderTests] [testCurrentHeaderVersion] after test
This change adjusts the test to only corrupt the file once, which is certain
not to leave the file in its original state.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
dnhatn
approved these changes
Jan 11, 2020
DaveCTurner
added a commit
that referenced
this pull request
Jan 12, 2020
Today we make multiple attempts to corrupt the translog header in `TranslogHeaderTests#testCurrentHeaderVersion`, but if we are extraordinarily unlucky then this sequence of corruptions may restore the file to its original state. This change adjusts the test to only corrupt the file once, which is certain not to leave the file in its original state.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Today we make multiple attempts to corrupt the translog header in `TranslogHeaderTests#testCurrentHeaderVersion`, but if we are extraordinarily unlucky then this sequence of corruptions may restore the file to its original state. This change adjusts the test to only corrupt the file once, which is certain not to leave the file in its original state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we make multiple attempts to corrupt the translog header in
TranslogHeaderTests#testCurrentHeaderVersion, but if we are extraordinarilyunlucky then this sequence of corruptions may restore the file to its original
state. An example of such an extraordinarily unlucky run is as follows.
Log output:
This change adjusts the test to only corrupt the file once, which is certain
not to leave the file in its original state.