Correct search_after handling #50629
Conversation
| // TODO: finalize the endpoints | ||
| controller.registerHandler(GET, "/{index}/_eql/search", this); | ||
| controller.registerHandler(POST, "/{index}/_eql/search", this); | ||
| final String path = "/{index}/_eql/search"; |
There was a problem hiding this comment.
Could you make a constant out of this?
| for (int i = 0; i < size; i++) { | ||
| arr.add(randomAlphaOfLength(randomIntBetween(1, 15))); | ||
| private SearchAfterBuilder randomJsonSearchFromBuilder() throws IOException { | ||
| int numSearchAfter = randomIntBetween(1, 10); |
There was a problem hiding this comment.
normally SearchAfter doesn't accept the empty list, throws error:
java.lang.IllegalArgumentException: Values must contains at least one value.
The original searchafter test doesn't use empty list as well
There was a problem hiding this comment.
How about returning setting search after values to null sometimes then?
There was a problem hiding this comment.
Already handled there as well
java.lang.NullPointerException: Values cannot be null.
at __randomizedtesting.SeedInfo.seed([1C63F70E75AEE77B:48BB964652FCDAE7]:0)
at org.elasticsearch.search.searchafter.SearchAfterBuilder.setSortValues(SearchAfterBuilder.java:78)
There was a problem hiding this comment.
discussed over slack, updated implementation
| jsonBuilder.startObject(); | ||
| jsonBuilder.startArray("search_after"); | ||
| for (int i = 0; i < numSearchAfter; i++) { | ||
| int branch = randomInt(9); |
There was a problem hiding this comment.
I think there is LuceneTests.randomSortValue() that generates random sort values. I wonder if we could use it here.
There was a problem hiding this comment.
If it is not possible, I think there is a better pattern for this base on randomFrom(...) and Supplier<...>
There was a problem hiding this comment.
updated to a better pattern
aleksmaus
force-pushed
the
fix/eql_search_after_handling
branch
from
1717177 to
68ee15f
Compare
aleksmaus
force-pushed
the
fix/eql_search_after_handling
branch
from
68ee15f to
1bd4327
Compare
Correct the initial "naive" handling of search_after parameters.