[ML] Unmute BWC tests and fix version after backport of #50553 #50599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
run elasticsearch-ci/2 |
benwtrent
reviewed
Jan 3, 2020
| @@ -40,7 +40,7 @@ private DeleteDataFrameAnalyticsAction() { | |||
| public Request(StreamInput in) throws IOException { | |||
| super(in); | |||
| id = in.readString(); | |||
| if (in.getVersion().onOrAfter(Version.CURRENT)) { | |||
| if (in.getVersion().onOrAfter(Version.V_8_0_0)) { | |||
There was a problem hiding this comment.
Since #50589 is merged, shouldn't the version be V_7_6_0?
There was a problem hiding this comment.
since BWC has passed with the version being wrong, I am guessing we don't have a BWC test that deletes analytics jobs do we?
There was a problem hiding this comment.
Ah, 🤦♂
Indeed. I'll add one that creates and deletes a job in the mixed cluster.
benwtrent
approved these changes
Jan 3, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #50553