Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate User metadata with OpenIDConnect collections #50521

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Dec 30, 2019

The OpenIdConnectRealm had a bug which would cause it not to populate
User metadata for collections contained in the user JWT claims.

This commit fixes that bug.

Resolves: #50250

The OpenIdConnectRealm had a bug which would cause it not to populate
User metadata for collections contained in the user JWT claims.

This commit fixes that bug.

Resolves: elastic#50250
@tvernum tvernum added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.6.0 labels Dec 30, 2019
@tvernum tvernum requested a review from jkakavas December 30, 2019 06:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ auto-complete woes. Thanks

@tvernum
Copy link
Contributor Author

tvernum commented Jan 8, 2020

@elasticmachine update branch

@tvernum
Copy link
Contributor Author

tvernum commented Jan 8, 2020

@elasticmachine run elasticsearch-ci/2

@tvernum tvernum merged commit 7e12d5a into elastic:master Jan 8, 2020
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jan 13, 2020
The OpenIdConnectRealm had a bug which would cause it not to populate
User metadata for collections contained in the user JWT claims.

This commit fixes that bug.

Resolves: elastic#50250
Backport of: elastic#50521
tvernum added a commit that referenced this pull request Jan 13, 2020
The OpenIdConnectRealm had a bug which would cause it not to populate
User metadata for collections contained in the user JWT claims.

This commit fixes that bug.

Backport of: #50521
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
The OpenIdConnectRealm had a bug which would cause it not to populate
User metadata for collections contained in the user JWT claims.

This commit fixes that bug.

Resolves: elastic#50250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect "Collections" type check in OpenID Connect Realm
4 participants