Optimize composite aggregation based on index sorting (#48399) #50272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Huang <[email protected]> This is a spinoff of elastic#48130 that generalizes the proposal to allow early termination with the composite aggregation when leading sources match a prefix or the entire index sort specification. In such case the composite aggregation can use the index sort natural order to early terminate the collection when it reaches a composite key that is greater than the bottom of the queue. The optimization is also applicable when a query other than match_all is provided. However the optimization is deactivated for sources that match the index sort in the following cases: * Multi-valued source, in such case early termination is not possible. * missing_bucket is set to true
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 19, 2019
This commit adapts the version checks of the InternalComposite serialization after the backport of elastic#50272. Note that this pr disables bwc tests since elastic#50272 is not merged yet.
jimczi
added a commit
that referenced
this pull request
Dec 20, 2019
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 20, 2019
Merged
jimczi
added a commit
that referenced
this pull request
Dec 20, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This commit adapts the version checks of the InternalComposite serialization after the backport of elastic#50272. Note that this pr disables bwc tests since elastic#50272 is not merged yet.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48399