Correctly handle duplicates in unordered interval matching #49775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unordered interval matching does not check for duplicates,
which means that a query for
to be or not to be
can match a documentthat contains the phrase
to be or not
, because the secondto be
matchesat the same position as the first and the
AND
interval algorithm does notcheck for overlaps. This is counter-intuitive.
This commit adds a check to the interval builder, such that if it finds duplicates
when combining sources into an unordered
AND
, it combines those duplicatesinto an
ORDERED
interval first; soto be or not to be
becomesUNORDERED(ORDERED(to, to), ORDERED(be, be), or, not)