[ML] Only report complete writing_results progress after completion #49551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We depend on the number of data frame rows in order to report progress for the writing of results, the last phase of a job run. However, results include other objects than just the data frame rows (e.g, progress, inference model, etc.). The problem this commit fixes is that if we receive the last data frame row results we'll report that progress is complete even though we still have more results to process potentially. If the job gets stopped for any reason at this point, we will not be able to restart the job properly as we'll think that the job was completed. This commit addresses this by limiting the max progress we can report for the writing_results phase before the results processor completes to 98. At the end, when the process is done we set the progress to 100.
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Nov 25, 2019
| @@ -107,11 +114,22 @@ public void process(AnalyticsProcess<AnalyticsResult> process) { | |||
| failure = "error parsing data frame analytics output: [" + e.getMessage() + "]"; | |||
| } | |||
| } finally { | |||
| if (isCancelled == false) { | |||
There was a problem hiding this comment.
Should we take into account failure != null? It seems weird to me that we are "complete" even if we failed.
There was a problem hiding this comment.
Very good point. I also took the opportunity to improve failure reporting in that class in general.
przemekwitek
approved these changes
Nov 26, 2019
| assertThat(resultProcessor.getFailure(), equalTo("error processing results; some failure")); | ||
|
|
||
| ArgumentCaptor<String> auditCaptor = ArgumentCaptor.forClass(String.class); | ||
| verify(auditor).error(eq(JOB_ID), auditCaptor.capture()); |
There was a problem hiding this comment.
Is it possible to replace auditCaptor.capture() with containsString("Error processing results; some failure")?
There was a problem hiding this comment.
We need to call capture() on the captor for it to capture the argument to the mocked method.
dimitris-athanasiou
deleted the
only-report-complete-progress-after-completion
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 26, 2019
…ion (elastic#49551) We depend on the number of data frame rows in order to report progress for the writing of results, the last phase of a job run. However, results include other objects than just the data frame rows (e.g, progress, inference model, etc.). The problem this commit fixes is that if we receive the last data frame row results we'll report that progress is complete even though we still have more results to process potentially. If the job gets stopped for any reason at this point, we will not be able to restart the job properly as we'll think that the job was completed. This commit addresses this by limiting the max progress we can report for the writing_results phase before the results processor completes to 98. At the end, when the process is done we set the progress to 100. The commit also improves failure capturing and reporting in the results processor. Backport of elastic#49551
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 26, 2019
…ion (#49551) (#49577) We depend on the number of data frame rows in order to report progress for the writing of results, the last phase of a job run. However, results include other objects than just the data frame rows (e.g, progress, inference model, etc.). The problem this commit fixes is that if we receive the last data frame row results we'll report that progress is complete even though we still have more results to process potentially. If the job gets stopped for any reason at this point, we will not be able to restart the job properly as we'll think that the job was completed. This commit addresses this by limiting the max progress we can report for the writing_results phase before the results processor completes to 98. At the end, when the process is done we set the progress to 100. The commit also improves failure capturing and reporting in the results processor. Backport of #49551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on the number of data frame rows in order to report progress
for the writing of results, the last phase of a job run. However, results
include other objects than just the data frame rows (e.g, progress, inference model, etc.).
The problem this commit fixes is that if we receive the last data frame row results
we'll report that progress is complete even though we still have more results to process
potentially. If the job gets stopped for any reason at this point, we will not be able
to restart the job properly as we'll think that the job was completed.
This commit addresses this by limiting the max progress we can report for the
writing_results phase before the results processor completes to 98.
At the end, when the process is done we set the progress to 100.