Fix extraction of notarized Elasticsearch release distribution #49511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a workaround for an issue related to our recent notarization of distributions starting with the 6.8.5 release. An unintended side effect of notarization was that the file entries of the release tar all have a `./` prefix in the path. This causes a number of issues, not least of which is that our Gradle extract tasks end up copying an empty fileset to the destination directory. The workaround here is imply to remove the leading `./` path segment from each file when performing the extraction. For more details see this issue: elastic#49417
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
|
I'm going to go ahead and merge this to sort out the CI failures. |
mark-vieira
added a commit
that referenced
this pull request
Nov 23, 2019
This commit introduces a workaround for an issue related to our recent notarization of distributions starting with the 6.8.5 release. An unintended side effect of notarization was that the file entries of the release tar all have a `./` prefix in the path. This causes a number of issues, not least of which is that our Gradle extract tasks end up copying an empty fileset to the destination directory. The workaround here is imply to remove the leading `./` path segment from each file when performing the extraction. For more details see this issue: #49417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a workaround for an issue related to our recent
notarization of distributions starting with the 6.8.5 release. An
unintended side effect of notarization was that the file entries of the
release tar all have a
./prefix in the path. This causes a number ofissues, not least of which is that our Gradle extract tasks end up
copying an empty fileset to the destination directory. The workaround
here is imply to remove the leading
./path segment from each filewhen performing the extraction. For more details see this issue:
#49417