Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindex naming changes #49482

Merged

Conversation

henningandersen
Copy link
Contributor

@henningandersen henningandersen commented Nov 22, 2019

Renamed types and action names to fit that we now call it a reindex task
and not a job. Removed action and named writeable todos.

Relates #42612

Summary of action names:

  • reindex : the name of the persistent task action, will be running with [c] suffix. Other examples are: xpack/ml/datafeed, xpack/ccr/shard_follow_task, xpack/rollup/job and data_frame/transforms.
  • indices:data/write/reindex/start, the transport action for starting the reindex task. Chose this to allow security to use wildcard after reindex.

Renamed types and action names to fit that we now call it a reindex task
and not a job. Removed action and named writeable todos.

Relates elastic#42612
@henningandersen henningandersen added >non-issue :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down labels Nov 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Reindex)

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henningandersen henningandersen merged commit 375f3d8 into elastic:reindex_v2 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >non-issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants