Reindex resume from status #49255
Merged
Reindex resume from status #49255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reindex now uses last known good status on failure to ensure that counts continue from where it left when a node fails. Also added `persistentTaskId` to `StartReindexResponse` and removed a couple of obsolete todos. Relates elastic#42612
henningandersen
added
>non-issue
:Distributed Indexing/Reindex
|
Pinging @elastic/es-distributed (:Distributed/Reindex) |
Tim-Brooks
reviewed
Dec 10, 2019
| @@ -244,6 +248,25 @@ public void rethrottle(float newRequestsPerSecond) { | |||
| } | |||
| } | |||
|
|
|||
| public void resetStatus(BulkByScrollTask.Status checkpointStatus) { | |||
There was a problem hiding this comment.
Maybe initStatus? or setInitialStatus?
| out.writeOptionalWriteable(reindexResponse); | ||
| } | ||
|
|
||
| public String getTaskId() { | ||
| return taskId; | ||
| } | ||
|
|
||
| public String getPersistentTaskId() { |
There was a problem hiding this comment.
I was just working on this on a different branch and I feel like the persistent task id should be the default naming? As in the methods are getTaskId or getReindexTaskId? And the other one be getEphemeralTaskId? Or getCoordinatorNodeTaskId? Or getInitialEphemeralTaskId?
…_resume_from_status
…_resume_from_status
…_resume_from_status
…_resume_from_status
…_resume_from_status
…_resume_from_status
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix-unix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reindex now uses last known good status on failure to ensure that counts
continue from where it left when a node fails.
Also added
persistentTaskIdtoStartReindexResponseand removed acouple of obsolete todos.
Relates #42612