Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send the fields param via body instead of URL params (elastic#42232) #48840

Merged

Conversation

peonone
Copy link
Contributor

@peonone peonone commented Nov 3, 2019

It fixes #42232
I referred to the conversation from #42877 for the fix.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

@hub-cap
Copy link
Contributor

hub-cap commented Nov 11, 2019

@elasticmachine ok to test

@hub-cap
Copy link
Contributor

hub-cap commented Nov 11, 2019

Thanks for the submission! it looks great.

@hub-cap hub-cap self-assigned this Nov 11, 2019
@hub-cap
Copy link
Contributor

hub-cap commented Dec 12, 2019

Sorry this fell off my radar, getting to it now.

@hub-cap
Copy link
Contributor

hub-cap commented Dec 12, 2019

@elasticmachine update branch

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once this passes tests I can get it merged and backported.

@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@dakrone dakrone requested a review from danhermann February 20, 2020 15:08
@danhermann
Copy link
Contributor

@elasticmachine update branch

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peonone, thanks for the contribution! I'll get this merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MTermVector Java High Level Client Misses Fields Property
7 participants