Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code] Remove code_admin/code_user roles #48164

Closed
wants to merge 2 commits into from
Closed

[Code] Remove code_admin/code_user roles #48164

wants to merge 2 commits into from

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Oct 16, 2019

We currently use the Kibana Feature Control to manage user access control. And thus the roles in elasticsearch is not required anymore.

Addressing https://github.com/elastic/code/issues/1659

@tvernum
Copy link
Contributor

tvernum commented Oct 17, 2019

@mw-ding Elasticsearch PRs need to be labelled with:

  • one or more version labels (starting with v) that indicate which versions this change will target
  • one area label (starting with :) that indicate which functional area this change affects
  • one change-type label (starting with >) to control how it should be shown in the release notes.

I can add the last 2, but can you please add version labels, thanks.

@tvernum tvernum added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >enhancement labels Oct 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authorization)

@mw-ding
Copy link
Contributor Author

mw-ding commented Oct 17, 2019

@tvernum Done, please take a look. Also, do you think the failed tests here are relevant?

@tvernum
Copy link
Contributor

tvernum commented Oct 18, 2019

@mw-ding This failure https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-1/9039/testReport/junit/org.elasticsearch.client.documentation/SecurityDocumentationIT/testGetRoles/ is definitely related.
Can you update that test to reflect the removal of these roles?

The other one doesn't appear to be.

@mw-ding
Copy link
Contributor Author

mw-ding commented Oct 22, 2019

@tvernum the test has been updated. There is still a packaging-sample-matrix test failing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants