Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILM HLRC Javadoc->Documentation links #48083

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Oct 15, 2019

Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.

Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the javadoc URLs are broken on 2 lines like the following

     *  https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/
     *  java-rest-high-ilm-ilm-delete-lifecycle-policy.html

@dakrone
Copy link
Member

dakrone commented Oct 15, 2019

the javadoc URLs are broken on 2 lines like the following

This is unfortunately because of the 140 character limit. It's a sad side effect.

@gwbrown
Copy link
Contributor Author

gwbrown commented Oct 15, 2019

Opened #48089 for the test failure.
@elasticmachine run elasticsearch-ci/2

@gwbrown
Copy link
Contributor Author

gwbrown commented Oct 15, 2019

The failing tests have been muted in master.
@elasticmachine update branch

@gwbrown gwbrown merged commit 53c2b08 into elastic:master Oct 16, 2019
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Oct 16, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit that referenced this pull request Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit that referenced this pull request Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit that referenced this pull request Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
gwbrown added a commit that referenced this pull request Oct 17, 2019
Several links from the ILM HLRC Javadoc to the online documentation were
not updated when the ILM HLRC documentation was written. This commit
fixes those links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants