[Transform] prevent assignment to nodes older than 7.4 #48044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
|
run elasticsearch-ci/2 |
|
run elasticsearch-ci/bwc |
benwtrent
reviewed
Oct 15, 2019
| node.isDataNode() && | ||
| // see gh#48019 older nodes might not be able to read documents | ||
| node.getVersion().onOrAfter(Version.V_7_4_0) && | ||
| node.getVersion().onOrAfter(params.getVersion()) |
There was a problem hiding this comment.
I think we should not allow assignment at all in a mixed cluster where a <= 7.3 node is present. If the task is running and somebody makes a stats call, that stats call could be made against a 7.3 node which queries the wrong index and incorrectly says that the transform does not exist.
|
superseeded by #48055 |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not allow assignment of transforms to nodes older than 7.4 (in mixed clusters).
fixes #48019