Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /api/security/saml/callback as Kibana ACS URL. #47999

Merged

Conversation

azasypkin
Copy link
Member

In elastic/kibana#47929 Kibana dropped /api/security/v1/saml (deprecated since 7.5) route in favor of /api/security/saml/callback (in 8.0+). In this PR I'm just updating all references to already deprecated /api/security/v1/saml Kibana ACS URL.

@azasypkin azasypkin added >docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 labels Oct 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jkakavas
Copy link
Member

There are a lot of these that need to fixed in cloud (ESS/ECE/ ECE RBAC ) docs. It will be definitely more tricky there as we do maintain docs for older versions too

@azasypkin
Copy link
Member Author

There are a lot of these that need to fixed in cloud (ESS/ECE/ ECE RBAC ) docs. It will be definitely more tricky there as we do maintain docs for older versions too

Yeah, we'll need to figure that out anyway, with NP migration in Kibana we may have more of PRs like this one in the near future.

@azasypkin azasypkin requested a review from jkakavas October 15, 2019 08:02
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did a search and we do not seem to be using the v1 urls anywhere else

@azasypkin azasypkin merged commit 8aca85b into elastic:master Oct 15, 2019
@azasypkin azasypkin deleted the issue-xxx-rename-kibana-saml-endpoint branch October 15, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants