Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync before trimUnreferencedReaders to improve index preformance #47790

Merged
merged 12 commits into from
Oct 9, 2019
Merged

sync before trimUnreferencedReaders to improve index preformance #47790

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
624729e
Merge pull request #1 from elastic/master
dengweisysu Aug 21, 2019
9986233
do sync before closeIntoReader to make sure we move most of the data …
dengweisysu Aug 21, 2019
96e9741
modify comments in Translog.rollGeneration
dengweisysu Aug 21, 2019
113625b
Merge branch 'master' into master
elasticmachine Aug 21, 2019
5097ed2
Merge pull request #2 from elastic/master
dengweisysu Aug 26, 2019
fbbf8b5
Merge pull request #3 from elastic/master
dengweisysu Aug 31, 2019
448682a
trimUnreferencedReaders: move sync translog operation outside writeLock
dengweisysu Aug 31, 2019
e6744c2
trimUnreferencedReaders: move try-catch inside if condition
dengweisysu Sep 2, 2019
e951021
Merge branch 'master' into master
elasticmachine Sep 2, 2019
d485026
Merge pull request #4 from elastic/master
dengweisysu Sep 11, 2019
50a4f37
Merge pull request #5 from elastic/master
dengweisysu Oct 9, 2019
c2dbddc
trimUnreferencedReaders: sync before write lock
dengweisysu Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/src/main/java/org/elasticsearch/index/translog/Translog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,8 @@ public void rollGeneration() throws IOException {
* required generation
*/
public void trimUnreferencedReaders() throws IOException {
// move most of the data to disk to reduce the time the lock is held
sync();
try (ReleasableLock ignored = writeLock.acquire()) {
if (closed.get()) {
// we're shutdown potentially on some tragic event, don't delete anything
Expand Down Expand Up @@ -1697,6 +1699,7 @@ public void trimUnreferencedReaders() throws IOException {
// We now update the checkpoint to ignore the file we are going to remove.
// Note that there is a provision in recoverFromFiles to allow for the case where we synced the checkpoint
// but crashed before we could delete the file.
// sync at once to make sure that there's at most one unreferenced generation.
current.sync();
deleteReaderFiles(reader);
}
Expand Down