Add Consistency Assertion to SnapshotsInProgress #47598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert given input shards and indices are consistent. Also, fixed the equality check for SnapshotsInProgress. Before this change the tests never had more than a single waiting shard per index so they never failed as a result of the waiting shards list not being ordered. Follow up to elastic#47552
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
…snapshots-in-progress-entry
original-brownbear
changed the title
|
Thanks Yannick! |
original-brownbear
deleted the
assert-reasonable-snapshots-in-progress-entry
branch
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 7, 2019
Assert given input shards and indices are consistent. Also, fixed the equality check for SnapshotsInProgress. Before this change the tests never had more than a single waiting shard per index so they never failed as a result of the waiting shards list not being ordered. Follow up to elastic#47552
original-brownbear
added a commit
that referenced
this pull request
Oct 7, 2019
Assert given input shards and indices are consistent. Also, fixed the equality check for SnapshotsInProgress. Before this change the tests never had more than a single waiting shard per index so they never failed as a result of the waiting shards list not being ordered. Follow up to #47552
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47552 combined with the related follow up backport of elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failures when multiple data-nodes are lost during the snapshot process or shard snapshot failures have occured before a node left the cluster.
5 tasks
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 28, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Dec 2, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Dec 2, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Dec 2, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above. (cherry picked from commit ed3aea5)
mkleen
added a commit
to crate/crate
that referenced
this pull request
Dec 5, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above. (cherry picked from commit ed3aea5)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Dec 5, 2019
This pull request is a backport of two closely related pull requests: elastic/elasticsearch#47552 elastic/elasticsearch#47598 The purpose of this pull request is to track shard snapshots and mark them as failed when either multiple data-nodes are lost during the snapshot process or shard snapshot failures occure before a node left the cluster. Before this was not the case, so a failed shard would not have been marked as failed during the snapshot finalization. The problem is fixed by correctly keeping track of all previous completed shard states as well in this case and add a consistency assertion to SnapshotsInProgress. More details can be found in the original prs mentioned above. (cherry picked from commit ed3aea5)
original-brownbear
restored the
assert-reasonable-snapshots-in-progress-entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert given input shards and indices are consistent.
Also, fixed the equality check for SnapshotsInProgress.
Before this change the tests never had more than a single waiting
shard per index so they never failed as a result of the
waiting shards list not being ordered.
Fixed by not including the waiting field in the equals and hash methods as it is calculated quasi-deterministically (except for ordering) from
shardsanyway.Follow up to #47552