Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of evaluation response. #47557

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Oct 4, 2019

Serialization and deserialization routines for EvaluateDataFrameAction.Response were not in sync since #41937.
This PR fixes that.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Just left a suggestion to fortify a bit more.

@przemekwitek
Copy link
Contributor Author

Good catch! Just left a suggestion to fortify a bit more.

Suggestion applied. PTAL

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 7213035 into elastic:master Oct 4, 2019
@przemekwitek przemekwitek deleted the evaluation_response_fix branch October 4, 2019 10:57
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants