Add CooldownEsThreadPoolExecutor #47522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a special kind of thread pool executor that runs operations in a single-threaded manner, but with a configurable cooldown in between. The executor is always forced to have a single fixed thread with a configurable queue size. This special executor is not currently used, but is part of work for elastic#47520
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
gwbrown
reviewed
Oct 3, 2019
rjernst
reviewed
Oct 4, 2019
There was a problem hiding this comment.
Are there any other intended uses than delaying reading from s3? I'm hesitant to add another specialized execute for such a narrow use case. Is there a problem with holding a thread while polling (with backoff) for consistency to catch up? This should normally be a very short time right?
| logger.error("interrupted while waiting for [{}/{}s] cooldown to elapse (max cooldown: {})", | ||
| TimeValue.timeValueMillis(cooldownRemainingMillis), | ||
| TimeValue.timeValueMillis(cooldownRemainingMillis).seconds(), | ||
| TimeValue.timeValueMillis(cooldownMillis)); |
There was a problem hiding this comment.
Shouldn't the interrupt be restored?
Thread.currentThread().interrupt();
|
Given the discussion in #47520, I think we can close this? |
|
Yep, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a special kind of thread pool executor that runs operations in a
single-threaded manner, but with a configurable cooldown in between. The
executor is always forced to have a single fixed thread with a
configurable queue size.
This special executor is not currently used, but is part of work for #47520