DocValueFormat implementation for date range fields #47472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>bug
:Analytics/Aggregations
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
polyfractal
approved these changes
Oct 4, 2019
| @@ -136,35 +137,35 @@ calculated over the ranges of all matching documents. | |||
| "november_data" : { | |||
| "buckets" : [ | |||
| { | |||
| "key" : 1572220800000, | |||
There was a problem hiding this comment.
I think the doc tests are failing because date_histo will show both the key and key_as_string. E.g.
{
"key_as_string": "2015-01-01",
"key": 1420070400000,
"doc_count": 3
},
This was referenced Oct 4, 2019
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Oct 4, 2019
not-napoleon
added a commit
that referenced
this pull request
Oct 4, 2019
polyfractal
pushed a commit
that referenced
this pull request
Oct 11, 2019
39 tasks
24 tasks
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 31, 2020
range fields didn't have doc_values before 7.4.1. They were added in elastic#47472.
nik9000
added a commit
that referenced
this pull request
Jan 31, 2020
range fields didn't have doc_values before 7.4.1. They were added in #47472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47323
This PR adds support for resolving
DocValueFormatfor date ranges. Other range types are not supported, which is consistent with how ranges work elsewhere in the system. Prior to this change, attempting to use a format string in theDateHistogramover a range field generated an exception.There's a little bit of risk with this change, since
docValueFormatgets used in a lot of places (see #47469 ).