Clarify that you cannot abort an upgrade #47342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added
>docs
|
Pinging @elastic/es-docs |
|
Pinging @elastic/es-distributed |
DaveCTurner
commented
Oct 1, 2019
| earlier versions cannot read. The only way to revert an incomplete upgrade is to | ||
| completely delete the contents of the data path on each upgraded node. If this | ||
| results in data loss then you will need to restore the lost data from a | ||
| snapshot. |
There was a problem hiding this comment.
I am wondering if this remains open to interpretation. Maybe we should make a stronger statement that suggests you must discard the whole cluster if an upgrade fails.
There was a problem hiding this comment.
On reflection I think we have to say that. We don't test the node-by-node downgrade I suggested earlier, and it's definitely possible that the cluster state gets changed by a single upgraded node in a way that poisons the older nodes and e.g. prevents a second upgrade attempt.
I pushed 29d4ac8.
ywelsch
reviewed
Oct 1, 2019
| started to upgrade your cluster to version {version} you must complete the | ||
| upgrade. As soon as the cluster contains nodes of version {version} it may make | ||
| changes to its internal state that cannot be reverted. If you cannot complete | ||
| the upgrade then you must deploy an empty cluster and restore its contents from |
There was a problem hiding this comment.
Perhaps you could start the section with this. Currently this feels hidden away in the bullet point about snapshots, whereas this is not only a property of that.
There was a problem hiding this comment.
Thanks for the suggestion, yes, it looks good there; see http://elasticsearch_47342.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/restart-upgrade.html#restart-upgrade
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2019
We do mention that rolling back an upgrade requires a restore from a snapshot, but it's hidden at the bottom of the "preparing to upgrade" instructions on a different page from the actual upgrade instructions. This commit duplicates the preparatory instructions onto the pages containing the actual upgrade instructions and rewords the point about rollbacks a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do mention that rolling back an upgrade requires a restore from a snapshot,
but it's hidden at the bottom of the "preparing to upgrade" instructions on a
different page from the actual upgrade instructions. This commit duplicates the
preparatory instructions onto the pages containing the actual upgrade
instructions and rewords the point about rollbacks a bit.