[ML][Inference] Adding preprocessors to definition object #47320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
przemekwitek
approved these changes
Oct 1, 2019
| TRAINED_MODEL); | ||
| PARSER.declareNamedObjects(TrainedModelDefinition.Builder::setPreProcessors, | ||
| (p, c, n) -> p.namedObject(PreProcessor.class, n, null), | ||
| (trainedModelDefBuilder) -> {/* Does not matter client side*/ }, |
There was a problem hiding this comment.
nit: Could you make comments in lines 48 and 52 equal?
| @@ -242,6 +230,9 @@ public int hashCode() { | |||
| } | |||
|
|
|||
|
|
|||
| public static class Definition { | |||
There was a problem hiding this comment.
This is not needed, is it?
benwtrent
deleted the
feature/ml-inference-add-preprocessors-to-model-obj
branch
benwtrent
added a commit
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the definition of a trained model, we should include the pre-processing that needs to occur based on the training data.