Speed up Snapshot Finalization #47283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of elastic#45689 snapshot finalization started to take significantly longer than before. This may be a little unfortunate since it increases the likelihood of failing to finalize after having written out all the segment blobs. This change parallelizes all the metadata writes that can safely run in parallel in the finalization step to speed the finalization step up again. Also, this will generally speed up the snapshot process overall in case of large number of indices.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
|
Jenkins run elasticsearch-ci/bwc |
|
Jenkins run elasticsearch-ci/bwc |
| final RepositoryData updatedRepositoryData = getRepositoryData().addSnapshot(snapshotId, blobStoreSnapshot.state(), indices); | ||
| snapshotFormat.write(blobStoreSnapshot, blobContainer(), snapshotId.getUUID(), false); | ||
| writeIndexGen(updatedRepositoryData, repositoryStateId); | ||
| } catch (FileAlreadyExistsException ex) { |
There was a problem hiding this comment.
This catch is gone now, it was dead code because we don't do the exists check for this blob anymore in the line above where we write the snap- blob.
| indexMetaDataFormat.write(clusterMetaData.index(index.getName()), indexContainer(index), snapshotId.getUUID(), false); | ||
| } | ||
| } catch (IOException ex) { | ||
| throw new SnapshotException(metadata.name(), snapshotId, "failed to write metadata for snapshot", ex); |
There was a problem hiding this comment.
I removed this specific rethrow because we write the index meta in parallel to the root level snap- blob with this change anyway so throwing with a separate message here seemed pointless.
|
|
||
| public class MockEventuallyConsistentRepositoryTests extends ESTestCase { | ||
|
|
||
| private Environment environment; |
There was a problem hiding this comment.
This is just dead-code. Saw it when making adjustments here and just removed it when because I figured it wasn't worth a separate PR.
tlrx
reviewed
Sep 30, 2019
server/src/main/java/org/elasticsearch/repositories/Repository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/snapshots/SourceOnlySnapshotRepository.java
Show resolved
Hide resolved
|
Thanks @tlrx , all points addressed I think :) |
|
Jenkins run elasticsearch-ci/packaging-sample |
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 30, 2019
As a result of elastic#45689 snapshot finalization started to take significantly longer than before. This may be a little unfortunate since it increases the likelihood of failing to finalize after having written out all the segment blobs. This change parallelizes all the metadata writes that can safely run in parallel in the finalization step to speed the finalization step up again. Also, this will generally speed up the snapshot process overall in case of large number of indices. This is also a nice to have for elastic#46250 since we add yet another step (deleting of old index- blobs in the shards to the finalization.
original-brownbear
added a commit
that referenced
this pull request
Sep 30, 2019
As a result of #45689 snapshot finalization started to take significantly longer than before. This may be a little unfortunate since it increases the likelihood of failing to finalize after having written out all the segment blobs. This change parallelizes all the metadata writes that can safely run in parallel in the finalization step to speed the finalization step up again. Also, this will generally speed up the snapshot process overall in case of large number of indices. This is also a nice to have for #46250 since we add yet another step (deleting of old index- blobs in the shards to the finalization.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
5 tasks
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Nov 27, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated. (cherry picked from commit 3091e26)
mkleen
added a commit
to crate/crate
that referenced
this pull request
Nov 28, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated. (cherry picked from commit 3091e26)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Nov 28, 2019
This pull request is a backport of elastic/elasticsearch#47283 The purpose of this pull request is to speed up the snapshot finalization. This is archived by parallelizing the writes of the metadata in the snapshot finalization step. Also, this will generally speed up the snapshot process overall in case of large number of indices. This improvement makes sense, because the snapshot finalization takes much longer since #9327 is integrated. (cherry picked from commit 3091e26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #45689 snapshot finalization started to
take significantly longer than before. This may be a
little unfortunate since it increases the likelihood
of failing to finalize after having written out all
the segment blobs.
This change parallelizes all the metadata writes that
can safely run in parallel in the finalization step to
speed the finalization step up again. Also, this will
generally speed up the snapshot process overall in case
of large number of indices.
This is also a nice to have for #46250 since we add yet
another step (deleting of old
index-blobs in the shardsto the finalization.