Address invalid monitoring configuration that prevents Elasticsearch from starting #47249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is sufficient becuase
the settings by catching the exception and logging it.
This implementation is not ideal becuase
with only a message to the log
via the REST API.
To notify the the user that the configuration is incorrect via the
REST API and prevent persisting config to cluster state, one would
need to implement a validator via
clusterService.getClusterSettings().addAffixUpdateConsumer(HOST_SETTING , consumer, validator)
However, this is not done becuase
refactored out the validation bits)
being set, just easy access to the single setting. This is an affix
setting with other highly correlated settings needed to determine
correctness. The validator sees settings 1 by 1, not the full set
of settings being set.
[1] invalid config got into cluster state the exception would be thrown
to the cluster state applier, not the REST layer.
xpack.monitoring.exporters.foo.use_ingest
will exibit the same behaviorif
foo
has not been defined.Fixes #47125
EDIT: removed an incorrect statement