Move ES_TMPDIR substitution into jvm options parser

[jasontedor]

This commit moves the ES_TMPDIR substitution that we do for JVM options into the JVM options parser itself. This solves a problem where the fact that the we do not make the substitution before ergonomics parsing can lead to the JVM that we start for computing the ergonomic values failing to start. Additionally, moving this substitution here enables us to simplify the shell scripts since we do not need to implement this there, and twice for Bash and Windows.

Closes #47133

[elasticmachine]

Pinging @elastic/es-core-infra

[jasontedor]

@rjernst This is only a draft, I need to add tests, and actually test this on Windows (I haven't) so no need for a formal review, really looking for feedback on the direction I'm taking this.

[rjernst]

The direction looks good.

[jasontedor]

@rjernst This is ready for you.

[jasontedor]

@rjernst Can you review?

[probakowski]

This method can be simplified with use of mathce.appendReplacement method:

private static final Pattern SUBSTITUTION_PATTERN = Pattern.compile("\\$\\{([^}]+)}");

static List<String> substitutePlaceholders(final List<String> jvmOptions, Map<String, String> substitutions) {
    return jvmOptions.stream().map(jvmOption -> {
        StringBuilder sb = new StringBuilder();
        Matcher matcher = SUBSTITUTION_PATTERN.matcher(jvmOption);
        while (matcher.find()) {
            matcher.appendReplacement(sb, substitutions.get(matcher.group(1)));
        }
        matcher.appendTail(sb);
        return sb.toString();
    }).collect(Collectors.toList());
}

Or made faster (~2x) when you replace regex with indexOf:

static List<String> substitutePlaceholders(final List<String> jvmOptions, Map<String, String> substitutions) {
    final Map<String, String> placeholderSubstitutions =
            substitutions.entrySet().stream().collect(Collectors.toMap(e -> "${" + e.getKey() + "}", Map.Entry::getValue));
    return jvmOptions.stream().map(jvmOption -> {
        String actualJvmOption = jvmOption;
        int start = jvmOption.indexOf("${");
        if (start >= 0 && jvmOption.indexOf('}', start) > 0) {
            for (final Map.Entry<String, String> placeholderSubstitution : placeholderSubstitutions.entrySet()) {
                actualJvmOption = actualJvmOption.replace(placeholderSubstitution.getKey(), placeholderSubstitution.getValue());
            }
        }
        return actualJvmOption;
    }).collect(Collectors.toList());
}

[jasontedor]

Thanks for the suggestion @probakowski, I pushed it.

[rjernst]

LGTM. I do think @przemek-grzedzielski 's alternative to use indexOf is simpler.