Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Document missing query parms for cat recovery API #47181

Merged
merged 4 commits into from
Sep 27, 2019
Merged

[DOCS] Document missing query parms for cat recovery API #47181

merged 4 commits into from
Sep 27, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 26, 2019 •
edited
Loading

Documents the following query parameters for
the /_cat/recovery API:

  • active_only
  • detailed
  • index

Closes #41986

@jrodewig
[DOCS] Document missing query parms for cat recovery API
43d4346 
Documents the following query parameters for
the /_cat/recovery API:

* `active_only`
* `detailed`
* `index`
@jrodewig jrodewig added >docs General docs changes :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. :Data Management/CAT APIs Text APIs behind /_cat v8.0.0 v7.3.0 v7.5.0 v7.4.1 labels Sep 26, 2019
@jrodewig jrodewig requested a review from tlrx September 26, 2019 19:23
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

tlrx
tlrx approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a comment about a missing `

docs/reference/cat/recovery.asciidoc Outdated
@@ -13,6 +13,8 @@ to the <<indices-recovery, indices recovery>> API.

`GET /_cat/recovery/<index>`

`GET /_cat/recovery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ` at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @tlrx. Fixed with cc118f7.

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

@jrodewig
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample

@jrodewig jrodewig merged commit 4568d30 into elastic:master Sep 27, 2019
@jrodewig jrodewig deleted the doc-missing-cat-recover-parms branch September 27, 2019 16:19
This was referenced Sep 27, 2019
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request Sep 27, 2019
@jrodewig
[DOCS] Document missing query parms for cat recovery API (#47181) (#4…
5bf4376 
…7236)

Documents the following query parameters for
the /_cat/recovery API:

* `active_only`
* `detailed`
* `index`
jrodewig added a commit that referenced this pull request Sep 27, 2019
@jrodewig
[DOCS] Document missing query parms for cat recovery API (#47181) (#4…
ba84d99 
…7237)

Documents the following query parameters for
the /_cat/recovery API:

* `active_only`
* `detailed`
* `index`
jrodewig added a commit that referenced this pull request Sep 27, 2019
@jrodewig
[DOCS] Document missing query parms for cat recovery API (#47181) (#4…
b98c57a 
…7235)

Documents the following query parameters for
the /_cat/recovery API:

* `active_only`
* `detailed`
* `index`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrx tlrx tlrx approved these changes

Assignees
No one assigned
Labels
:Data Management/CAT APIs Text APIs behind /_cat :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >docs General docs changes v7.3.0 v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cat recovery API documentation is not complete
4 participants
@jrodewig @elasticmachine @tlrx @jakelandis