Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OriginationDate parsing tests. #47170

Merged

Conversation

andreidan
Copy link
Contributor

@andreidan andreidan commented Sep 26, 2019

Drop the usage of SimpleDateFormat and use the DateFormatter instead.

Fixes #47143

Drop the usage of `SimpleDateFormat` and use the `DateFormatter` instead
@andreidan andreidan added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Sep 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan
Copy link
Contributor Author

retest this please

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

@andreidan andreidan merged commit 7cf509a into elastic:master Sep 27, 2019
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Sep 27, 2019
* Fix OriginationDate parsing tests.

Drop the usage of `SimpleDateFormat` and use the `DateFormatter` instead

(cherry picked from commit 7cf509a)
Signed-off-by: Andrei Dan <[email protected]>
andreidan added a commit that referenced this pull request Sep 27, 2019
Drop the usage of `SimpleDateFormat` and use the `DateFormatter` instead

(cherry picked from commit 7cf509a)
Signed-off-by: Andrei Dan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport pending :Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexLifecycleInitialisationTests.testExplainParseOriginationDate fails on master branch
4 participants