Fix bind failure logging for mock transport #47150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the MockNioTransport uses a custom exception handler for server channel exceptions. This means that bind failures are logged at the warn level. This commit modifies the transport to use the common TcpTransport exception handler which will log exceptions at the correct level.
Tim-Brooks
added
>test
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Sep 26, 2019
| @@ -240,8 +240,7 @@ public MockSocketChannel createChannel(NioSelector selector, SocketChannel chann | |||
| @Override | |||
| public MockServerChannel createServerChannel(NioSelector selector, ServerSocketChannel channel, Config.ServerSocket socketConfig) { | |||
| MockServerChannel nioServerChannel = new MockServerChannel(channel); | |||
| Consumer<Exception> exceptionHandler = (e) -> logger.error(() -> | |||
| new ParameterizedMessage("exception from server channel caught on transport layer [{}]", channel), e); | |||
| Consumer<Exception> exceptionHandler = (e) -> onServerException(nioServerChannel, e);; | |||
There was a problem hiding this comment.
NIT: pointless () around e can go away snd and double ;; :)
Tim-Brooks
added a commit
that referenced
this pull request
Sep 27, 2019
Currently the MockNioTransport uses a custom exception handler for server channel exceptions. This means that bind failures are logged at the warn level. This commit modifies the transport to use the common TcpTransport exception handler which will log exceptions at the correct level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MockNioTransport uses a custom exception handler for
server channel exceptions. This means that bind failures are logged at
the warn level. This commit modifies the transport to use the common
TcpTransport exception handler which will log exceptions at the correct
level.