Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] move root endpoint to _transform with BWC layer #47127

Merged
merged 22 commits into from
Oct 7, 2019
Merged

[Transform] move root endpoint to _transform with BWC layer #47127

merged 22 commits into from
Oct 7, 2019

Conversation

hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Sep 25, 2019 •
edited
Loading

moves the main endpoint to /_transform/ from /_data_frame/transforms/ with providing backwards compatibility and deprecation warnings

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs hendrikmuhs force-pushed the rename-to-transform-action-names branch from 14da31f to 63ba04b Compare September 30, 2019 12:41
@hendrikmuhs hendrikmuhs changed the title [Transform] POC for renaming actions [Transform] Rename actions with BWC layer Sep 30, 2019
@hendrikmuhs hendrikmuhs force-pushed the rename-to-transform-action-names branch 3 times, most recently from 312aeae to 126ca31 Compare October 1, 2019 14:05
@hendrikmuhs hendrikmuhs force-pushed the rename-to-transform-action-names branch from fe9cb80 to 5a373ae Compare October 2, 2019 07:27
@hendrikmuhs hendrikmuhs changed the title [Transform] Rename actions with BWC layer [Transform] move root endpoint to _transform with BWC layer Oct 2, 2019
@hendrikmuhs hendrikmuhs marked this pull request as ready for review October 2, 2019 12:38
@hendrikmuhs
Copy link
Author

run elasticsearch-ci/default-distro

@benwtrent benwtrent self-requested a review October 7, 2019 10:58
benwtrent
benwtrent approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ultimate deletion will cause more churn than normal, BUT the deletion will be easier as we don't have to worry about if(restRequest.path().startsWith(...)) sort of conditionals.

👍

@hendrikmuhs hendrikmuhs merged commit e9e121c into elastic:master Oct 7, 2019
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this pull request Oct 7, 2019
[Transform] move root endpoint to _transform with BWC layer (elastic#…
73317af 
…47127)

move the main endpoint to /_transform/ from /_data_frame/transforms/ with providing backwards compatibility and deprecation warnings
@hendrikmuhs hendrikmuhs mentioned this pull request Oct 7, 2019
Merged
hendrikmuhs pushed a commit that referenced this pull request Oct 8, 2019
[Transform] move root endpoint to _transform with BWC layer (#47127) (#…
5e0e54f 
…47682)

move the main endpoint to /_transform/ from /_data_frame/transforms/ with providing backwards compatibility and deprecation warnings
@joegallo joegallo mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform >refactoring v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikmuhs @elasticmachine @benwtrent @jakelandis