Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Check case where the pivot limit is reached #47121

Merged
merged 3 commits into from
Sep 26, 2019
Merged

SQL: Check case where the pivot limit is reached #47121

merged 3 commits into from
Sep 26, 2019

Conversation

costin
Copy link
Member

@costin costin commented Sep 25, 2019

In some cases, the fetch size affects the way the groups are returned
causing the last page to beyond the limit. Add dedicated check to
prevent extra data from being returned.

Fix #47002

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin
SQL: Check case where the pivot limit is reached
76b5bbf 
In some cases, the fetch size affects the way the groups are returned
causing the last page to beyond the limit. Add dedicated check to
prevent extra data from being returned.

Fix elastic#47002
@costin
Copy link
Member Author

costin commented Sep 25, 2019

@elasticmachine run @elasticsearch-ci/2

matriv
matriv reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add also a test for this in FetchSizeTestCase?
Minor, for commit message:

... causing the last page to beyond the limit. ...

I think a verb is missing in this phrasing?

@costin
Copy link
Member Author

costin commented Sep 26, 2019

@elasticmachine run @elasticsearch-ci/2 elasticsearch-ci/bwc

matriv
matriv approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin
Copy link
Member Author

costin commented Sep 26, 2019

@elasticmachine run @elasticsearch-ci/bwc

@costin costin merged commit f4c2964 into elastic:master Sep 26, 2019
@costin costin deleted the fix/47002 branch September 26, 2019 16:47
costin added a commit that referenced this pull request Sep 26, 2019
@costin
SQL: Check case where the pivot limit is reached (#47121)
b29a2cb 
In some cases, the fetch size affects the way the groups are returned
causing the last page to go beyond the limit. Add dedicated check to
prevent extra data from being returned.

Fix #47002

(cherry picked from commit f4c2964)
@costin costin mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@astefan astefan Awaiting requested review from astefan

@bpintea bpintea Awaiting requested review from bpintea

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] org.elasticsearch.xpack.sql.qa.single_node.JdbcCsvSpecIT failures
4 participants
@costin @elasticmachine @matriv @jakelandis