Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused private methods and fields #47115

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Sep 25, 2019

This commit removes a bunch of unused private fields (mostly unused deprecation loggers) and unused private methods from the codebase.

(labeling this with :Search/Search as many unused code are related to search changes)

@tlrx tlrx added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.5.0 labels Sep 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlrx Thanks, nice job in cleaning the code!

@tlrx tlrx merged commit b1a03a1 into elastic:master Sep 26, 2019
@tlrx tlrx deleted the kill-code branch September 26, 2019 07:36
@tlrx
Copy link
Member Author

tlrx commented Sep 26, 2019

Thanks @mayya-sharipova

tlrx added a commit that referenced this pull request Sep 26, 2019
This commit removes a bunch of unused private fields and unused
private methods from the code base.

Backport of (#47115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants