-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for building docker on debian 8 #47106
Conversation
Looks like there's a workaround with aufs used in debian 8. Adding `tsflags=nodocs` works around this issue and results in smaller image files also. Closes elastic#47097 and elastic/infra#14780
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This seems like a best practice for building Docker images as well, since as you say, it results in a smaller image.
RUN for iter in {1..10}; do yum update -y && \ | ||
yum install -y nc && \ | ||
RUN for iter in {1..10}; do yum update --setopt=tsflags=nodocs -y && \ | ||
yum install -y --setopt=tsflags=nodocs nc && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering how come this is needed as the base centos:7
image contains this flag in /etc/yum.conf
:
$ docker run --rm -ti centos:7 /bin/bash
[root@7969d2e1a52b /]# grep nodocs /etc/yum.conf
tsflags=nodocs
Looks like there's a workaround with aufs used in debian 8. Adding `tsflags=nodocs` works around this issue and results in smaller image files also. Closes #47097 and elastic/infra#14780
Looks like there's a workaround with aufs used in debian 8. Adding `tsflags=nodocs` works around this issue and results in smaller image files also. Closes #47097 and elastic/infra#14780
Looks like there's a workaround with aufs used in debian 8. Adding `tsflags=nodocs` works around this issue and results in smaller image files also. Closes #47097 and elastic/infra#14780
Looks like there's a workaround with aufs used in debian 8. Adding `tsflags=nodocs` works around this issue and results in smaller image files also. Closes #47097 and elastic/infra#14780
Looks like there's a workaround with aufs used in debian 8.
Adding
tsflags=nodocs
works around this issue and results in smallerimage files also.
Closes #47097 and elastic/infra#14780