Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for building docker on debian 8 #47106

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Sep 25, 2019

Looks like there's a workaround with aufs used in debian 8.
Adding tsflags=nodocs works around this issue and results in smaller
image files also.

Closes #47097 and elastic/infra#14780

Looks like there's a workaround with aufs used in debian 8.
Adding `tsflags=nodocs` works around this issue and results in smaller
image files also.

Closes elastic#47097 and elastic/infra#14780
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems like a best practice for building Docker images as well, since as you say, it results in a smaller image.

@alpar-t alpar-t merged commit 119daf7 into elastic:master Sep 30, 2019
@alpar-t alpar-t deleted the docker-build-debian-8 branch September 30, 2019 06:34
RUN for iter in {1..10}; do yum update -y && \
yum install -y nc && \
RUN for iter in {1..10}; do yum update --setopt=tsflags=nodocs -y && \
yum install -y --setopt=tsflags=nodocs nc && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering how come this is needed as the base centos:7 image contains this flag in /etc/yum.conf:

$ docker run --rm -ti centos:7 /bin/bash
[root@7969d2e1a52b /]# grep nodocs /etc/yum.conf
tsflags=nodocs

alpar-t added a commit that referenced this pull request Sep 30, 2019
Looks like there's a workaround with aufs used in debian 8.
Adding `tsflags=nodocs` works around this issue and results in smaller
image files also.

Closes #47097 and elastic/infra#14780
alpar-t added a commit that referenced this pull request Sep 30, 2019
Looks like there's a workaround with aufs used in debian 8.
Adding `tsflags=nodocs` works around this issue and results in smaller
image files also.

Closes #47097 and elastic/infra#14780
alpar-t added a commit that referenced this pull request Sep 30, 2019
Looks like there's a workaround with aufs used in debian 8.
Adding `tsflags=nodocs` works around this issue and results in smaller
image files also.

Closes #47097 and elastic/infra#14780
alpar-t added a commit that referenced this pull request Sep 30, 2019
Looks like there's a workaround with aufs used in debian 8.
Adding `tsflags=nodocs` works around this issue and results in smaller
image files also.

Closes #47097 and elastic/infra#14780
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image build fails on Debian 8 with cpio: cap_set_file
5 participants