Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for POST requests to SLM Execute API #47061

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Sep 25, 2019

This commit adds support for POST requests to the SLM _execute API,
because POST is a more appropriate HTTP verb for this action as it is
not idempotent. The docs are also changed to favor POST over PUT,
although PUT is not removed or officially deprecated.

This commit adds support for POST requests to the SLM `_execute` API,
because POST is a more appropriate HTTP verb for this action as it is
not idempotent. The docs are also changed to favor POST over PUT,
although PUT is not removed or officially deprecated.
@gwbrown gwbrown added :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.5.0 labels Sep 25, 2019
@gwbrown gwbrown requested a review from dakrone September 25, 2019 01:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@gwbrown
Copy link
Contributor Author

gwbrown commented Sep 25, 2019

@dakrone If we did want to deprecate PUT, e51266c is all that would be required - all the tests I can find pass with the changes here + deprecating PUT.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown gwbrown merged commit b42923f into elastic:master Sep 25, 2019
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Sep 25, 2019
This commit adds support for POST requests to the SLM `_execute` API,
because POST is a more appropriate HTTP verb for this action as it is
not idempotent. The docs are also changed to favor POST over PUT,
although PUT is not removed or officially deprecated.
gwbrown added a commit that referenced this pull request Sep 25, 2019
This commit adds support for POST requests to the SLM `_execute` API,
because POST is a more appropriate HTTP verb for this action as it is
not idempotent. The docs are also changed to favor POST over PUT,
although PUT is not removed or officially deprecated.
@Mpdreamz
Copy link
Member

@gwbrown deprecation would be good IMO but will need some changes to the json spec too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants