Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Replace transforms with transform, index constants #47023

Merged
merged 6 commits into from
Sep 25, 2019
Merged

[Transform] Replace transforms with transform, index constants #47023

merged 6 commits into from
Sep 25, 2019

Conversation

hendrikmuhs
Copy link

  • replace "transforms" with "transform" for consistency
  • use constants for internal index naming wherever possible and document required changes

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@benwtrent benwtrent self-requested a review September 24, 2019 15:40
benwtrent
benwtrent approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hendrikmuhs hendrikmuhs merged commit 169ac92 into elastic:master Sep 25, 2019
hendrikmuhs pushed a commit that referenced this pull request Sep 25, 2019
[Transform] Replace transforms with transform, index constants (#47023)
7377ac4 
 - replace "transforms" with "transform" for consistency
 - use constants for internal index naming wherever possible and document required changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform >refactoring v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikmuhs @elasticmachine @benwtrent @jakelandis