Work around error building deb on Windows #47011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to elastic#47007 . the `gradle-ospackage-plugin` plugin doesn't properly support symlink on windows. This PR changes the way we configure tasks to prevent building these packages as part of a windows check.
|
Pinging @elastic/es-core-infra |
alpar-t
added
the
:Delivery/Packaging
|
@elasticmachine run elasticsearch-ci/packaging |
jasontedor
requested changes
Sep 25, 2019
@jasontedor viewing the diff with white space changes ignored shows a much better picture. All the lines got an additional indent following the suggestion made by Mark to avoid the |
|
@elasticmachine run elasticsearch-ci/2 |
|
Thanks for that @atorok. |
|
@elasticmachine run elasticsearch-ci/packaging There's a known issue, but this doesn't seem to be it. |
|
It looks like it takes more work to go to the latest version of the os distribution plugin. Reverting for now as it's not strictly needed for this change |
|
This time the failure is the one from #46903 |
alpar-t
added a commit
that referenced
this pull request
Sep 27, 2019
Relates to #47007 . the `gradle-ospackage-plugin` plugin doesn't properly support symlink on windows. This PR changes the way we configure tasks to prevent building these packages as part of a windows check.
alpar-t
added a commit
that referenced
this pull request
Sep 27, 2019
Relates to #47007 . the `gradle-ospackage-plugin` plugin doesn't properly support symlink on windows. This PR changes the way we configure tasks to prevent building these packages as part of a windows check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #47007 . the
gradle-ospackage-pluginplugin doesn'tproperly support symlink on windows.
This PR changes the way we configure tasks to prevent building these
packages as part of a windows check.