-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add multi-level example to nested query docs #46986
[DOCS] Add multi-level example to nested query docs #46986
Conversation
Pinging @elastic/es-docs |
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up. I left a comment about the example.
{ | ||
"driver" : { | ||
"vehicle" : { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in order to demonstrate why nested field & query are needed here a more complex
example should be shown here. The document should contain multiple drivers and models and
two match queries on two different model fields. Otherwise an mapping with regular object fields
and just match queries would work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback @martijnvg.
I added some more detail to the example with 0eb74e5 and 2dedd58.
This should make the example a bit more realistic and add two match queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a multi-level example to the nested query docs.
Closes #11830