Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add multi-level example to nested query docs #46986

Merged
merged 8 commits into from
Sep 25, 2019
Merged

[DOCS] Add multi-level example to nested query docs #46986

merged 8 commits into from
Sep 25, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 23, 2019

Adds a multi-level example to the nested query docs.

Closes #11830

@jrodewig jrodewig added the >docs General docs changes label Sep 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig added :Search/Search Search-related issues that do not fall into other categories v6.8.0 v7.0.0 v7.1.0 v7.2.0 v7.3.0 v7.4.0 v7.5.0 v8.0.0 labels Sep 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jrodewig jrodewig marked this pull request as ready for review September 23, 2019 21:56
docs/reference/query-dsl/nested-query.asciidoc Outdated Show resolved Hide resolved
docs/reference/query-dsl/nested-query.asciidoc Outdated Show resolved Hide resolved
@jrodewig jrodewig requested a review from debadair September 24, 2019 12:30
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. I left a comment about the example.

{
"driver" : {
"vehicle" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in order to demonstrate why nested field & query are needed here a more complex
example should be shown here. The document should contain multiple drivers and models and
two match queries on two different model fields. Otherwise an mapping with regular object fields
and just match queries would work too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @martijnvg.

I added some more detail to the example with 0eb74e5 and 2dedd58.

This should make the example a bit more realistic and add two match queries.

@jrodewig jrodewig requested a review from martijnvg September 24, 2019 15:25
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 0776153 into elastic:master Sep 25, 2019
@jrodewig jrodewig deleted the multi-level-nested-query-ex branch September 25, 2019 04:56
@jrodewig jrodewig removed the v6.8.0 label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 v7.1.0 v7.2.0 v7.3.0 v7.4.0 v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Multi-level nested query syntax, add more clarity in docs.
5 participants