Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds missing icons to ILM HLRC APIs #46633

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 11, 2019

This PR adds the missing "role=xpack" attribute to the index lifecycle management APIs in the Java high level REST client documentation ( https://www.elastic.co/guide/en/elasticsearch/client/java-rest/master/_index_lifecycle_management_apis.html)

@lcawl lcawl added >docs General docs changes :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 labels Sep 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown
Copy link
Contributor

gwbrown commented Sep 11, 2019

This is only tagged for 8.0, are we not backporting this change?

(If not that's fine, just a bit surprising to me)

@lcawl lcawl merged commit 5105db4 into elastic:master Sep 11, 2019
@lcawl lcawl deleted the ilm-hlrc branch September 11, 2019 22:45
@lcawl lcawl added the v7.5.0 label Sep 11, 2019
@lcawl lcawl added the v7.4.0 label Sep 11, 2019
@lcawl lcawl added the v7.3.3 label Sep 11, 2019
@lcawl lcawl added the v7.2.2 label Sep 11, 2019
@lcawl lcawl added the v7.1.2 label Sep 11, 2019
@lcawl lcawl added the v7.0.2 label Sep 11, 2019
@lcawl lcawl added the v6.8.4 label Sep 11, 2019
@lcawl
Copy link
Contributor Author

lcawl commented Sep 11, 2019

Thanks @gwbrown ! I've backported all the way to 6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants