-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove types from Get/MultiGet #46587
Conversation
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine test this please |
1 similar comment
@elasticmachine test this please |
I've chased down a bunch of test failures here due to a change in MultiGetRequestBuilder that doesn't get caught by the compiler. The This could introduce some quite nasty and hard-to-track-down bugs into client code over an upgrade. I think the best solution is probably to rename the |
retrofits typed get_source api removed in elastic#46931 and elastic#46587 relates elastic#51816
This commit removes types from the ShardGetService, and propagates this API change
up through the Transport and Rest actions for Get and MultiGet
Relates to #41059