Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform]Rename data frame plugin to transform: plugin and package names #46478

Merged
merged 8 commits into from
Sep 11, 2019
Merged

[Transform]Rename data frame plugin to transform: plugin and package names #46478

merged 8 commits into from
Sep 11, 2019

Conversation

hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Sep 9, 2019 •
edited
Loading

rename data frame transform plugin to transform:

  • rename plugin data-frame to transform
  • change all package names from o.e..dataframe. to o.e..transform.
  • necessary changes to fix loading/testing

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@hendrikmuhs hendrikmuhs changed the title [Transform]Rename to transform [Transform]Rename data frame plugin to transform plugin and package names Sep 9, 2019
@hendrikmuhs hendrikmuhs changed the title [Transform]Rename data frame plugin to transform plugin and package names [Transform]Rename data frame plugin to transform: plugin and package names Sep 9, 2019
@hendrikmuhs hendrikmuhs removed the WIP label Sep 9, 2019
@hendrikmuhs hendrikmuhs marked this pull request as ready for review September 9, 2019 09:45
dimitris-athanasiou
dimitris-athanasiou approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit c463ddb into elastic:master Sep 11, 2019
@hendrikmuhs hendrikmuhs mentioned this pull request Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
>breaking-java :ml/Transform Transform >refactoring v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikmuhs @elasticmachine @dimitris-athanasiou @jakelandis @droberts195