Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for background refresh in testAutomaticRefresh #45661

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 16, 2019

If the background refresh is running, but not finished yet then the document might not be visible to the next search. Thus, if scheduledRefresh returns false, we need to wait until the background refresh is done.

Closes #45571

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.4.0 v7.3.1 labels Aug 16, 2019
@dnhatn dnhatn requested a review from s1monw August 16, 2019 15:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Aug 20, 2019

Thanks @s1monw.

@dnhatn dnhatn merged commit dc6e3e2 into elastic:master Aug 20, 2019
@dnhatn dnhatn deleted the auto-refresh branch August 20, 2019 13:13
dnhatn added a commit that referenced this pull request Aug 20, 2019
If the background refresh is running, but not finished yet then the
document might not be visible to the next search. Thus, if
scheduledRefresh returns false, we need to wait until the background
refresh is done.

Closes #45571
dnhatn added a commit that referenced this pull request Aug 20, 2019
If the background refresh is running, but not finished yet then the
document might not be visible to the next search. Thus, if
scheduledRefresh returns false, we need to wait until the background
refresh is done.

Closes #45571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v7.3.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexShardIT#testAutomaticRefresh test failure
4 participants