Consider owner flag when retrieving/invalidating keys with API key service
#45421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service Actual invocation of API key service now takes `owner` flag from the request into consideration by setting the values for `realm` and `username` as per the current authentication. This allows for retrieving or invalidating API keys owned by the current authenticated user. Relates: #
bizybot
added
:Security/Authentication
|
Pinging @elastic/es-security |
|
Failed due to #43673 |
tvernum
reviewed
Aug 12, 2019
...security/src/main/java/org/elasticsearch/xpack/security/action/TransportGetApiKeyAction.java
Show resolved
Hide resolved
...y/src/main/java/org/elasticsearch/xpack/security/action/TransportInvalidateApiKeyAction.java
Show resolved
Hide resolved
...k/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
Outdated
Show resolved
Hide resolved
...k/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
Outdated
Show resolved
Hide resolved
...k/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
Outdated
Show resolved
Hide resolved
|
existing grok test failure |
colings86
added
>enhancement
and removed
:Security/Authentication
56 tasks
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual invocation of API key service now takes
ownerflag from therequest into consideration by setting the values for
realmandusernameas per the current authentication before invoking API key service.This allows for retrieving or invalidating API keys owned by the current
authenticated user.
Relates: #40031