Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Data Frame] have DataFrameTransformConfigUpdate#apply set Version #45391

Merged

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Aug 9, 2019

Bumping the version on update allows transforms that are updated, then stopped/started to be assigned to new nodes. This is so we can handle the case when an _update adds fields that older nodes don't recognize.

closes #45389

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

run elasticsearch-ci/1

2 similar comments
@benwtrent
Copy link
Member Author

run elasticsearch-ci/1

@benwtrent
Copy link
Member Author

run elasticsearch-ci/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML][Data Frame] _update should set transform version to latest
4 participants