Do not use scroll when finding duplicate API key #45026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create API key we check if the API key with the name already exists. It searches with scroll enabled and this causes the request to fail when creating large number of API keys in parallel as it hits the number of open scroll limit (default 500). We do not need the search context to be created so this commit removes the scroll parameter from the search request for duplicate API key.
bizybot
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
tvernum
approved these changes
Aug 1, 2019
|
Since this is a bug, can we backport to |
bizybot
added a commit
that referenced
this pull request
Aug 2, 2019
When we create API key we check if the API key with the name already exists. It searches with scroll enabled and this causes the request to fail when creating large number of API keys in parallel as it hits the number of open scroll limit (default 500). We do not need the search context to be created so this commit removes the scroll parameter from the search request for duplicate API key.
bizybot
added a commit
that referenced
this pull request
Aug 2, 2019
When we create API key we check if the API key with the name already exists. It searches with scroll enabled and this causes the request to fail when creating large number of API keys in parallel as it hits the number of open scroll limit (default 500). We do not need the search context to be created so this commit removes the scroll parameter from the search request for duplicate API key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create API key we check if the API key with the name
already exists. It searches with scroll enabled and this causes
the request to fail when creating a large number of API keys in
parallel as it hits the number of open scroll limit (default 500).
We do not need the search context to be created so this commit
removes the scroll parameter from the search request done for
a duplicate API key check.
Manual testing is done by creating 100K API keys (100 threads running in parallel)