Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo: move indexShape to AbstractGeometryFieldMapper.Indexer #44979

Merged
merged 4 commits into from
Jul 30, 2019

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jul 29, 2019

Move indexShape functionality into AbstractGeometryFieldMapper to make
it more unit testable.

Move indexShape functionality into AbstractGeometryFieldMapper to make
it more unit testable.
@imotov imotov added :Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v8.0.0 v7.4.0 labels Jul 29, 2019
@imotov imotov requested a review from nknize July 29, 2019 19:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Merged and tested locally w/ #44980 and this makes the field mapper code far more elegant and easier to follow. LGTM!

@imotov imotov merged commit 7e627d2 into elastic:master Jul 30, 2019
imotov added a commit that referenced this pull request Jul 30, 2019
Move indexShape functionality into AbstractGeometryFieldMapper to make
it more unit testable.

Relates to #43644
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
Move indexShape functionality into AbstractGeometryFieldMapper to make
it more unit testable.

Relates to #43644
@imotov imotov deleted the move-indexshape-into-indexer branch May 1, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants