Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal Streamable #44647

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Removal Streamable #44647

merged 1 commit into from
Jul 20, 2019

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jul 20, 2019

This commit ends the grand adventure that was the
refactoring effort to migrate all usages of
Streamable to Writeable.

Closes #34389.

This commit ends the grand adventure that was the
refactoring effort to migrate all usages of
Streamable to Writeable.

Closes elastic#34389.
@talevy talevy added :Core/Infra/Core Core issues without another label >refactoring v8.0.0 v7.4.0 labels Jul 20, 2019
@talevy talevy requested a review from rjernst July 20, 2019 02:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@talevy talevy merged commit 5e89cd9 into elastic:master Jul 20, 2019
@talevy talevy deleted the streamable-no-more branch July 20, 2019 05:12
talevy added a commit that referenced this pull request Jul 21, 2019
This commit ends the grand adventure that was the
refactoring effort to migrate all usages of
Streamable to Writeable.

Closes #34389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] Migrate Usages of Streamable to Writeable
4 participants