-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformat has_parent
query docs
#44443
Conversation
Pinging @elastic/es-search |
Pinging @elastic/es-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jrodewig! This is a nice rework of this documentation.
"term" : { | ||
"tag" : "something" | ||
} | ||
"match_all" : {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what is the purpose of this has_parent
query with "match_all" : {}
query inside? Is it to retrieve all child docs (something that we warned against)? May be a better example would be to have a more specific query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great point! I update the index setup and query examples with 31c720a.
Instead of match_all
, it now uses a term
query similar to the previous example.
querying multiple indexes which might have different mappings. When set to | ||
`false` (the default value) the query will throw an exception if the `type` | ||
is not mapped. | ||
If `false`, {es} ignores the relevance score of the parent document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be also mention here, that in the case of false
, the child docs' scores will be equal to boost
of has_parent
query which defaults to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added with 4f290ab.
Thanks so much for your review @mayya-sharipova. |
Rewrites the
has_parent
query to use the new query format.This creates separate sections for example requests, parameters, and notes.
This is part of #40977, an effort to standardize documentation for query types.
Before
Before image
After
After image