Support WKT point conversion to geo_point type #44107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
|
@elasticmachine test this please |
imotov
reviewed
Jul 9, 2019
server/src/main/java/org/elasticsearch/common/geo/GeoPoint.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/GeoPoint.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/GeoPointFieldMapper.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/search/geo/GeoPointParsingTests.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/geo/parsers/GeoWKTParser.java
Outdated
Show resolved
Hide resolved
-fix parameters in docs -use WellKnownText parser -add negative tests
|
@elasticmachine test this please |
|
I've found the cause of SQL query failure. I'll see what can be done with it. |
|
Perhaps the division of logic between FieldMapper parser and GeoUtil is not quite right. |
|
The reason was in code duplication. Namely, the same check |
|
@elasticmachine test this please |
|
Do you have any idea why these tests failed? Something flaky again? Maybe I need to merge with master? |
|
@elasticmachine run elasticsearch-ci/bwc |
|
Yeah, might be good idea to merge in master. |
|
Merged. |
|
@elasticmachine test this please |
|
@talevy, done. |
|
thanks! @elasticmachine test this please |
imotov
pushed a commit
that referenced
this pull request
Jul 12, 2019
This PR adds support for parsing geo_point values from WKT POINT format. Also, a few minor bugs in geo_point parsing were fixed. Closes #41821
56 tasks
39 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 13, 2019
Relates: elastic/elasticsearch#44107 This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization honours the original form deserialized from.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 14, 2019
Relates: elastic/elasticsearch#44107 This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization honours the original form deserialized from.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 14, 2019
Relates: elastic/elasticsearch#44107 This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization honours the original form deserialized from. (cherry picked from commit 3f3f98c)
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 14, 2019
Relates: elastic/elasticsearch#44107 This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization honours the original form deserialized from. (cherry picked from commit 3f3f98c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing
geo_pointvalues from WKT POINT format.Also, a few minor bugs in
geo_pointparsing were fixed.Closes #41821