Decouple DiskThresholdMonitor & ClusterInfoService #44105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `ClusterInfoService` requires the `DiskThresholdMonitor` at construction time so that it can notify it when nodes report changes in their disk usage, but this is awkward to construct: the `DiskThresholdMonitor` requires a `RerouteService` which requires an `AllocationService` which comees from the `ClusterModule` which requires the `ClusterInfoService`. Today we break the cycle with a `LazilyInitializedRerouteService` which is itself a little ugly. This commit replaces this with a more traditional subject/observer relationship between the `ClusterInfoService` and the `DiskThresholdMonitor`.
|
Opened for discussion with @rjernst, no plan to merge this yet so no labels. |
DaveCTurner
added
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed |
DaveCTurner
added a commit
that referenced
this pull request
Jul 9, 2019
Today the `ClusterInfoService` requires the `DiskThresholdMonitor` at construction time so that it can notify it when nodes report changes in their disk usage, but this is awkward to construct: the `DiskThresholdMonitor` requires a `RerouteService` which requires an `AllocationService` which comees from the `ClusterModule` which requires the `ClusterInfoService`. Today we break the cycle with a `LazilyInitializedRerouteService` which is itself a little ugly. This commit replaces this with a more traditional subject/observer relationship between the `ClusterInfoService` and the `DiskThresholdMonitor`.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 23, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 24, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 25, 2019
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Sep 25, 2019
Backport of elastic/elasticsearch#44105 (cherry picked from commit 67d1aa0)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Sep 25, 2019
Backport of elastic/elasticsearch#44105 (cherry picked from commit 67d1aa0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
ClusterInfoServicerequires theDiskThresholdMonitoratconstruction time so that it can notify it when nodes report changes in their
disk usage, but this is awkward to construct: the
DiskThresholdMonitorrequires a
RerouteServicewhich requires anAllocationServicewhich comeesfrom the
ClusterModulewhich requires theClusterInfoService.Today we break the cycle with a
LazilyInitializedRerouteServicewhich isitself a little ugly. This commit replaces this with a more traditional
subject/observer relationship between the
ClusterInfoServiceand theDiskThresholdMonitor.