Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GCP update #43632

Conversation

DaveCTurner
Copy link
Contributor

The changes in #43205 and friends mean that the GCP of the local shard is not advanced as expected any more, causing this test to fail.

@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Jun 26, 2019
@DaveCTurner DaveCTurner requested a review from ywelsch June 26, 2019 11:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit f5fdb75 into elastic:peer-recovery-retention-leases Jun 26, 2019
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 26, 2019
@DaveCTurner DaveCTurner deleted the 2019-06-25-fix-prrls-branch branch July 4, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants