-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo: Add coerce support to libs/geo WKT parser #43273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for coercing not closed polygons and ignoring Z value to libs/geo WKT parser. Closes elastic#43173
imotov
added
>bug
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
:Analytics/SQL
SQL querying
v8.0.0
v7.3.0
labels
Jun 17, 2019
Pinging @elastic/es-analytics-geo |
Pinging @elastic/es-search |
talevy
reviewed
Jun 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! left a few questions and comments
libs/geo/src/main/java/org/elasticsearch/geo/utils/WellKnownText.java
Outdated
Show resolved
Hide resolved
talevy
approved these changes
Jun 17, 2019
private static MultiPolygon parseMultiPolygon(StreamTokenizer stream) throws IOException, ParseException { | ||
/** | ||
* Treats supplied arrays as coordinates of a linear ring. If the ring is not closed and coerce is set to true, | ||
* the first set of coordinates (lat, lon and alt if available) are added to the end of the arrays.s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, trailing .s
imotov
added a commit
that referenced
this pull request
Jun 18, 2019
Adds support for coercing not closed polygons and ignoring Z value to libs/geo WKT parser. Closes #43173
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jun 19, 2019
Adds support for coercing not closed polygons and ignoring Z value to libs/geo WKT parser. Closes elastic#43173
imotov
added a commit
that referenced
this pull request
Jun 25, 2019
jpountz
removed
the
:Analytics/Geo
Indexing, search aggregations of geo points and shapes
label
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.
Closes #43173