Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo: Add coerce support to libs/geo WKT parser #43273

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jun 17, 2019

Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.

Closes #43173

Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.

Closes elastic#43173
@imotov imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/SQL SQL querying v8.0.0 v7.3.0 labels Jun 17, 2019
@imotov imotov requested a review from talevy June 17, 2019 10:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! left a few questions and comments

private static MultiPolygon parseMultiPolygon(StreamTokenizer stream) throws IOException, ParseException {
/**
* Treats supplied arrays as coordinates of a linear ring. If the ring is not closed and coerce is set to true,
* the first set of coordinates (lat, lon and alt if available) are added to the end of the arrays.s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, trailing .s

@imotov imotov merged commit f6a06d8 into elastic:master Jun 18, 2019
imotov added a commit that referenced this pull request Jun 18, 2019
Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.

Closes #43173
imotov added a commit to imotov/elasticsearch that referenced this pull request Jun 19, 2019
Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.

Closes elastic#43173
imotov added a commit that referenced this pull request Jun 25, 2019
…3367)

Adds support for coercing not closed polygons and ignoring Z value
to libs/geo WKT parser.

Backport of #42549 and #43273
Closes #43173
@jpountz jpountz removed the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Jul 5, 2019
@imotov imotov deleted the add-coerce-to-wkt-parser branch May 1, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: Handling of coerced WKT polygons
5 participants